This proposal resolves a storage creep issue in the Nouns' Descriptor contract, which has caused the gas required to settle an auction to increase with each added batch of traits.
A new descriptor contract has been deployed with a simple optimization that reduces auction settlement by 40,000 gas, and prevents future increases as traits are added.
The art in the new descriptor contract is identical to the descriptor that's currently used in production.
For those who are technical, you can find the full changes here.
Simulations of Reduction in Gas:
Solimander
FOR - 39 VOTES
akva556 | "⌐◨-◨"
brettdrawsstuff | "⌐◨-◨"
robotfishgirl | "oh god please yes I've spent half an eth settling auctions to date lmao"
benbodhi | "This is a big upgrade for both nouns and the many forks using the contracts. Much appreciated."
AGAINST - 2 VOTES
ABSTAINS - 2 VOTES
Good catch. Unblocks greater trait use. Note that while I do write Solidity, I haven't had time to personally audit this code.
Would consider a small retro fund for this change to incentivize open source maintenance. Primarily to signal that ongoing maintenance is valued.
sent from voter.wtf
https://www.lilnouns.wtf/vote/nounsdao/396/votes
FOR - 79 VOTES
sqx10.eth | "No one likes gas"
AGAINST - 0 VOTES
ABSTAINS - 8 VOTES
Thank you for implementing this! It's not only useful to nouns, but also the forks using the nouns contracts. Really appreciate the work that goes into things like this that benefit all participants.
For those wanting to verify that the art is unchanged: https://codepen.io/solimander/pen/wvmgRMP
This proposal resolves a storage creep issue in the Nouns' Descriptor contract, which has caused the gas required to settle an auction to increase with each added batch of traits.
A new descriptor contract has been deployed with a simple optimization that reduces auction settlement by 40,000 gas, and prevents future increases as traits are added.
The art in the new descriptor contract is identical to the descriptor that's currently used in production.
For those who are technical, you can find the full changes here.
Simulations of Reduction in Gas:
Solimander